Verify operator CSV images are from allowed registries #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarva
requested changes
Jul 30, 2024
nmars
force-pushed
the
olm_approved_registries
branch
from
e995c8f to
09b805a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 113 113
Lines 5621 5672 +51
=========================================
+ Hits 5621 5672 +51
|
nmars
force-pushed
the
olm_approved_registries
branch
from
09b805a to
dd2064e
Compare
lcarva
approved these changes
Aug 1, 2024
|
@nmars, one more thing. We require signed commits in this repo. |
auto-merge was automatically disabled
August 1, 2024 21:05
Head branch was pushed to by a user without write access
nmars
force-pushed
the
olm_approved_registries
branch
from
dd2064e to
d44d7cb
Compare
|
@lcarva signed commit added. |
|
/ok-to-test Edit: lol, looks like I don't have the power to approve workflows |
lcarva
approved these changes
Aug 2, 2024
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a rule that verifies that images from operator bundle CSVs are hosted on approved registries.
resolves: CVP-4149