Fix broken unregistration of 64bit type libraries (second attempt) #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UnRegisterTypeLib function currently always assume 32bit type libraries (SYS_WIN32) if called without explicit `syskind` argument. This is currently the case when UnRegisterTypeLib is called implicitly from comtypes.server.register.UseCommandLine, since the `_reg_typelib_` field only contains the first 3 libID , wVerMajor and wVerMinor arguments. Propose to fix the problem by updating the hardcoding to SYS_WIN64 for 64bit Python and SYS_WIN32 for 32bit Python installations.
forderud
changed the title
…atter suggestion.
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Dec 3, 2024
junkmd
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
The reproducer in your ComSamples repository and @bennyrowland ’s insights helped in approving this PR.
Reviving the COM server tests in this project will be addressed in a separate scope.
|
Thanks a lot for your rapid support on this @junkmd @bennyrowland. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UnRegisterTypeLibfunction currently always assume 32bit type libraries (SYS_WIN32) if called without explicitsyskindargument. This is currently the case whenUnRegisterTypeLibis called implicitly fromcomtypes.server.register.UseCommandLine, since the_reg_typelib_field only contains the first 3libID,wVerMajorandwVerMinorarguments.Propose to fix the problem by updating the hardcoding to
SYS_WIN64for 64bit Python andSYS_WIN32for 32bit Python installations. This ensures that existing 32bit COM servers continue to function on 32bit Python installations.