Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test\test_outparam.py] Use WinDLL/OleDLL instead of windll/oledll #765

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

moi15moi
Copy link
Contributor

See #735

Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoTaskMemFree is not solely for the GUID structure, so it might be better to define it in __init__.py or a new module rather than in comtypes/GUID.py.
Considering that CoTaskMemAlloc, IMalloc, CoGetMalloc (and potentially CoTaskMemRealloc) are valuable as COM utilities, there could be a dedicated module for these utilities.

That said, implementing such changes would exceed the scope of #735, so we should avoid addressing it here.
This is not something that needs to be resolved immediately, but rather a future consideration.

@junkmd junkmd added this to the 1.4.10 milestone Jan 26, 2025
@junkmd junkmd merged commit 183991d into enthought:main Jan 26, 2025
50 checks passed
@junkmd junkmd linked an issue Jan 26, 2025 that may be closed by this pull request
@moi15moi moi15moi deleted the Use-WinDLL/OleDLL-for-test_outparam branch February 1, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants