Reveal and fix a masked test #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the test method started with an underscore which is why unittest wasnt discovering it modified: traits/etsconfig/tests/test_etsconfig.py
|
The test failed as expected - Fixing it now. |
added 2 commits
July 17, 2022 12:46
we are making a strong assumption here that the tests are being run using unittest modified: traits/etsconfig/tests/test_etsconfig.py
modified: traits/etsconfig/tests/test_etsconfig.py
rahulporuri
changed the title
rahulporuri
changed the title
mdickinson
approved these changes
Jul 19, 2022
I have opened #1672 for this. |
mdickinson
pushed a commit
that referenced
this pull request
Aug 9, 2022
* DEV: Reveal a masked test method the test method started with an underscore which is why unittest wasnt discovering it modified: traits/etsconfig/tests/test_etsconfig.py * FIX: Update the app_name and get the test passing we are making a strong assumption here that the tests are being run using unittest modified: traits/etsconfig/tests/test_etsconfig.py * CLN: Remove the now unnecessary dundername/dundermain clause modified: traits/etsconfig/tests/test_etsconfig.py (cherry picked from commit f379908)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test name started with an underscore which is why unittest wasnt discovering it.
Once the leading underscore is removed, we noticed that the test assertion fails - because the
app_namethat the code infers by default is different.We update the assertion to pass - with the strong assumption that the tests are run using
unittest- which traits uses for test discovery and to run the tests.Checklist
TestsUpdate API reference (docs/source/traits_api_reference)Update User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs