Skip to content

Commit

Permalink
docs
Browse files Browse the repository at this point in the history
  • Loading branch information
JesseAbram committed Jul 16, 2024
1 parent 8017fea commit f633109
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions pallets/staking/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ pub mod pallet {
/// The weight information of this pallet.
type WeightInfo: WeightInfo;
}
// TODO: JA add build for initial endpoints


/// A unique identifier of a subgroup or partition of validators that have the same set of
/// threshold shares.
pub type SubgroupId = u8;
Expand Down Expand Up @@ -328,7 +327,7 @@ pub mod pallet {
.or(Err(Error::<T>::InvalidValidatorId))?;

pallet_staking::Pallet::<T>::withdraw_unbonded(origin, num_slashing_spans)?;
// TODO: do not allow unbonding of validator if not enough validators
// TODO: do not allow unbonding of validator if not enough validators https://github.com/entropyxyz/entropy-core/issues/942
if pallet_staking::Pallet::<T>::bonded(&controller).is_none() {
let server_info =
ThresholdServers::<T>::take(&validator_id).ok_or(Error::<T>::NoThresholdKey)?;
Expand Down Expand Up @@ -418,7 +417,7 @@ pub mod pallet {
) -> Result<(), DispatchError> {
let mut current_signers = Self::signers();
// Since not enough validators do not allow rotation
// TODO: open issue to discuss
// TODO: https://github.com/entropyxyz/entropy-core/issues/943
if validators.len() <= current_signers.len() {
return Ok(());
}
Expand Down

0 comments on commit f633109

Please sign in to comment.