Remove confirm_registered extrinsic
#1025
Conversation
This depends on being able to confirm the registration, which we don't do anymore
HCastano
added
Bump `spec_version`
| @@ -681,6 +679,7 @@ async fn test_program_with_config() { | |||
| clean_tests(); | |||
| } | |||
|
|
|||
| #[ignore] | |||
There was a problem hiding this comment.
This test fails because it depends on confirm_register working. I've ignored it for now because I want to use it as a reference when I start migrating the tests to use the new registration flow
There was a problem hiding this comment.
omg i can't wait to see this test get deleted it has been a pita
do we not already have tests which use the new registration flow?
There was a problem hiding this comment.
We do have them, but I want to go through the old tests to see if there are any failure conditions that I haven't checked in the new tests.
| /// Confirms that a address has finished registering on chain. | ||
| pub async fn confirm_registered( | ||
| /// Confirms that the network wide distributed key generation process has taken place. | ||
| pub async fn confirm_jump_start( | ||
| api: &OnlineClient<EntropyConfig>, | ||
| rpc: &LegacyRpcMethods<EntropyConfig>, | ||
| who: SubxtAccountId32, |
There was a problem hiding this comment.
Not sure if we still need this argument, or the check below since this should only ever be called with the network parent key but no harm in leaving it in.
There was a problem hiding this comment.
Yeah I think this can get cleaned up, but it'll be more clear how when I rip out the old registration flow
| @@ -681,6 +679,7 @@ async fn test_program_with_config() { | |||
| clean_tests(); | |||
| } | |||
|
|
|||
| #[ignore] | |||
There was a problem hiding this comment.
omg i can't wait to see this test get deleted it has been a pita
do we not already have tests which use the new registration flow?
|
|
||
| #[test] | ||
| fn it_provides_free_txs_confirm_done() { |
There was a problem hiding this comment.
Im guessing since we changed how we do 'free' transactions we don't need the equivalent of these tests for confirming jump start completed
There was a problem hiding this comment.
We're not doing free transactions for the jump start confirmation. If we do go down that route we may want to bring these back, but no point in keeping them around right now
This is another extrinsic which we don't need anymore as a part of the new registration
flow.