Bump synedrion to v0.2.0 release #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameba23
commented
Nov 28, 2024
| @@ -148,6 +149,10 @@ async fn test_reshare() { | |||
| if new_signer_ids != old_signer_ids { | |||
| break; | |||
| } | |||
| if i > 100 { | |||
There was a problem hiding this comment.
This is not relevant to this PR, but it was missing from #1185 - and i got a CI error in this PR which i think was caused by it: https://github.com/entropyxyz/entropy-core/actions/runs/12050178276/job/33598503963
I am pretty sure its not from a problem introduced by the new version of synedrion. (but you never know)
dvdplm
approved these changes
Dec 1, 2024
| @@ -148,6 +149,10 @@ async fn test_reshare() { | |||
| if new_signer_ids != old_signer_ids { | |||
| break; | |||
| } | |||
| if i > 100 { | |||
| panic!("Timed out waiting for reshare protocol to finish successfully"); | |||
There was a problem hiding this comment.
100 iters seem a bit random and it's not time based. If you want this to be a proper deadline, perhaps code it like
let start = std::time::Instant::now();
loop {
// do things
if start.elapsed() > std::time::Duration::from_secs(30) {
// log, and bail
}
}
HCastano
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps synedrion from v0.2.0-beta.0 to the released v0.2.0. Dependabot would probably eventually do this for us, but im not sure when that will happen and i would like to have it in before we make another release.
There is one small breaking change in the release:
KeyShare.verifying_key()now returns anOption<VerifyingKey>.And keyshare format has changed so pre-generated keyshares need updating.