Fix error handling for TDX quote generation in production #1192
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
entropy-tss
, real (non-mock) TDX quotes are currently only generated when theproduction
feature flag is enabled.Unfortunately that means the code behind that flag is not tested in CI. I recently set up a test network on TDX hardware to test attestation, and
entropy-tss
would not compile with theproduction
feature flag enabled due to the error type whichconfig-tsm::generate_quote
having changed. This PR fixes that.I have also made an issue to have the error type improved before the next release of
configfs-tsm
: entropyxyz/configfs-tsm#7We could also consider adding
cargo check -p entropy-tss --feature production
to our CI.