Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling for TDX quote generation in production #1192

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ameba23
Copy link
Contributor

@ameba23 ameba23 commented Dec 2, 2024

In entropy-tss, real (non-mock) TDX quotes are currently only generated when the production feature flag is enabled.

Unfortunately that means the code behind that flag is not tested in CI. I recently set up a test network on TDX hardware to test attestation, and entropy-tss would not compile with the production feature flag enabled due to the error type which config-tsm::generate_quote having changed. This PR fixes that.

I have also made an issue to have the error type improved before the next release of configfs-tsm: entropyxyz/configfs-tsm#7

We could also consider adding cargo check -p entropy-tss --feature production to our CI.

Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Yeah we definitely should be checking all the features during CI builds. I say we could even do it as part of this PR, but since we're not really testing on TDX hardware wait a bit to save ourselves the extra CI run time for now.

@ameba23 ameba23 merged commit 105d3e4 into master Dec 3, 2024
8 checks passed
@ameba23 ameba23 deleted the peg/fix-production-quote-error-handle branch December 3, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants