Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix for reshare issue #1201

Closed
wants to merge 6 commits into from

Conversation

JesseAbram
Copy link
Member

Currently reshare on testnet is failing due to a validation error that data is stale. This lines up the block number generated for reshare and the block number expected by the tss.

Regression test is difficult and needs more thinking.

@HCastano
Copy link
Collaborator

HCastano commented Dec 5, 2024

Can you make sure you test the runtime upgrade from v0.3.0 -> v0.3.1 on a locally running network first?

If you have time you could even do a dry run on a remote devnet. @entropyxyz/system-reliability-engineers may need to help you out with that if you haven't walked through the process before.

runtime/src/lib.rs Outdated Show resolved Hide resolved
@HCastano
Copy link
Collaborator

HCastano commented Dec 5, 2024

Oh I guess another consideration here actually is whether we want to run the full release pipeline and publish a v0.3.1 release 🤔

Co-authored-by: Hernando Castano <[email protected]>
@JesseAbram
Copy link
Member Author

Oh I guess another consideration here actually is whether we want to run the full release pipeline and publish a v0.3.1 release 🤔

I say not worth it, when this works Ill make these changes to master, this is really internal and touches no storage or external things

@JesseAbram
Copy link
Member Author

Can you make sure you test the runtime upgrade from v0.3.0 -> v0.3.1 on a locally running network first?

If you have time you could even do a dry run on a remote devnet. @entropyxyz/system-reliability-engineers may need to help you out with that if you haven't walked through the process before.

yup done and also did that with chopsticks a few weeks ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants