Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oracle data to cli #1222

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Add oracle data to cli #1222

merged 4 commits into from
Dec 20, 2024

Conversation

JesseAbram
Copy link
Member

@JesseAbram JesseAbram commented Dec 17, 2024

Allows the Cli to post oracle data pointers to chain

pairs with entropyxyz/programs#100

@JesseAbram JesseAbram requested review from HCastano and ameba23 and removed request for HCastano December 19, 2024 18:17
@JesseAbram JesseAbram marked this pull request as ready for review December 19, 2024 20:52
crates/test-cli/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ all looks great.

At first i was thinking that since these headers are small and likely human readable they dont really need to be put in a file and could be given on the command line. But actually it makes total sense since this file is generated automatically in the paired PR.

@JesseAbram JesseAbram merged commit a5c69b2 into master Dec 20, 2024
8 checks passed
@JesseAbram JesseAbram deleted the add-oracle-data-to-store-program branch December 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants