entropy-protocol - polkadot-js compatible sr25519 key generation for wasm API
#533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JesseAbram
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the how sr25519 secret keys are interpreted in
entropy-protocol's wasm API.In order to be compatible with sr25519 on polkadot-js we need to handle secret keys slightly differently than with
sp-core::sr25519.So that we can have the integration test work continue to work with the
sp_keyringaccounts, i've added a feature flag 'wasm-test' which will effectively use the same keypairs as before in the tests.I've also changed the API to take a secret key rather than a seed, as this is in-line with what we've done elsewhere (eg: in x25519chacha20poly1305`).
For context see this issue: entropyxyz/x25519-chacha20poly1305#15