Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add three-node devnet-local configuration #940

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Conversation

HCastano
Copy link
Collaborator

This adds a third node to our devnet-local chainspec and adds that to our Docker
Compose setup.

While the containers spin up correctly, I've ran into some issues around TSS accounts not
being funded properly and with signing not working on the test CLI. Since these issues
aren't exactly related to the Docker stuff I'm gonna dig into those in some different
PRs.

Closes #892.

@HCastano HCastano requested review from JesseAbram and vitropy July 16, 2024 20:19
Copy link
Contributor

@vitropy vitropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the atomicity of this PR! I think I caught a few minor port mismatches but otherwise it looks okay to my eyes.

docker-compose.yaml Show resolved Hide resolved
node/cli/src/chain_spec/dev.rs Outdated Show resolved Hide resolved
@HCastano HCastano requested a review from vitropy July 16, 2024 20:45
@HCastano HCastano merged commit 9482bb8 into master Jul 16, 2024
13 checks passed
@HCastano HCastano deleted the hc/three-node-docker branch July 16, 2024 21:50
@ameba23
Copy link
Contributor

ameba23 commented Jul 19, 2024

@HCastano

re: having issues with signing messages with this setup using the test-cli - just to confirm i was able to successfully register and sign using the test-cli. I just needed to add the line:

127.0.0.1 charlie-tss-server

to /etc/hosts - which probably needs adding to the readme.

So this is great!

Although that doesn't explain why you had issues with accounts not being funded. (i tried with Alice and that worked)

@HCastano
Copy link
Collaborator Author

@ameba23 I could've sworn I added that to the README guess it didn't make it into the PR 😅

I suspect my original problem stemmed from using the wrong port of Charlie in the config. For the record, here's the error I was running into during signing:

entropy-core on  hc/three-node-docker [!] via 🐳 desktop-linux via 🦀 v1.76.0 took 49s
❮ cargo run -p entropy-test-cli -- sign 0275e3086dce2392af6f4b9c9895d577d0fe1e7e7d425fa3fff6bd89c6f28d00f5 "Hello, Docker Compose"
    Finished dev [unoptimized + debuginfo] target(s) in 0.95s
     Running `target/debug/entropy-test-cli sign 0275e3086dce2392af6f4b9c9895d577d0fe1e7e7d425fa3fff6bd89c6f28d00f5 'Hello, Docker Compose'`
User account for current call: 5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY
Failed!
Error: Signing failed: Encryption or signing error: Hpke: HPKE Error: OpenError

As for the the accounts not being funded, are you not getting any warnings about that in the TSS logs at startup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker-compose script for using 3 validators
4 participants