Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New on-chain registration flow #955

Merged
merged 35 commits into from
Aug 6, 2024
Merged

New on-chain registration flow #955

Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
e4a8ad0
Trial of using types and derivation code
HCastano Jul 19, 2024
0ab281a
Move new registration code to its own extrinsic
HCastano Jul 19, 2024
08bb789
Use my branch of Synedrion
HCastano Jul 19, 2024
c763efc
Sketch out using the account ID as derivation path
HCastano Jul 19, 2024
fef5704
Basic test setup
HCastano Jul 19, 2024
9515834
Use a `CountedStorageMap` for `Registered` struct
HCastano Jul 21, 2024
8b11b4c
Add some error handling
HCastano Jul 21, 2024
53a428d
Tidy genesis build
HCastano Jul 21, 2024
9ff2ea6
Add registration struct for new flow
HCastano Jul 21, 2024
dd0f613
Use updated `RegisteredInfo` struct in tests
HCastano Jul 21, 2024
9426027
Test flow and validate verifying key
HCastano Jul 21, 2024
cdf0cfb
Encode the signature request account in place
HCastano Jul 22, 2024
8a30466
Update some of the variable names
HCastano Jul 22, 2024
46c410e
Revert registration struct to be indexed by verifying key
HCastano Jul 22, 2024
a0a9b16
Initialize `RegisteredOnChain` during genesis builds
HCastano Jul 22, 2024
9814934
Remove check that a `signature_request_account` can only register once
HCastano Jul 22, 2024
1d7fbdb
Insert verifying key into `ModifiableKeys` storage struct
HCastano Jul 22, 2024
2723aa9
Remove `dbg!` statement
HCastano Jul 22, 2024
0efb5f6
Add test to check that a signature request account can register multi…
HCastano Jul 22, 2024
3d8d334
Add benchmark for new registration extrisic
HCastano Jul 23, 2024
73a9c3f
Add comments around registration flow
HCastano Jul 23, 2024
57fc59a
Use `no_std` compatible version of Synedrion
HCastano Aug 1, 2024
2a7b4cb
Use `core` and `alloc` data structures in pallet
HCastano Aug 1, 2024
12fb5ec
Use remote Synedrion reference
HCastano Aug 1, 2024
11a65d9
Merge branch 'master' into hc/new-on-chain-registration-flow
HCastano Aug 2, 2024
86f1b21
Make derivation path in benchmarks generic instead of hardcoded
HCastano Aug 2, 2024
3923688
Use benchmark results for new extrinsic
HCastano Aug 2, 2024
6f02367
Rename extrinsic to `register_on_chain`
HCastano Aug 2, 2024
21d0eda
Use `no_std` functions for benches
HCastano Aug 2, 2024
64d6fdb
Add entry to `CHANGELOG`
HCastano Aug 2, 2024
ddc8f2d
Add a few tests for failure conditions
HCastano Aug 2, 2024
06fe835
Merge branch 'master' into hc/new-on-chain-registration-flow
HCastano Aug 2, 2024
7ffc56c
Fix breaking changes from #974
HCastano Aug 2, 2024
ac33b2a
Bump Synedrion to latest `master`
HCastano Aug 6, 2024
b4f41e1
Add issue number to `TODO` comment
HCastano Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ At the moment this project **does not** adhere to
- Jumpstart network ([#918](https://github.com/entropyxyz/entropy-core/pull/918))
- Add Signer groups and rotation ([#938](https://github.com/entropyxyz/entropy-core/pull/938))
- Split jumpstart and register flows ([#952](https://github.com/entropyxyz/entropy-core/pull/952))
- New on-chain registration flow ([#955](https://github.com/entropyxyz/entropy-core/pull/955))
- Reshare confirmation ([#965](https://github.com/entropyxyz/entropy-core/pull/965))
- Set inital signers ([#971](https://github.com/entropyxyz/entropy-core/pull/971))
- Add parent key threshold dynamically ([#974](https://github.com/entropyxyz/entropy-core/pull/974))
Expand Down
106 changes: 84 additions & 22 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pallets/registry/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ publish =false
targets=['x86_64-unknown-linux-gnu']

[dependencies]
bip32 ={ version="0.5.2", default-features=false, features=["alloc"] }
codec ={ package="parity-scale-codec", version="3.6.3", default-features=false, features=["derive"] }
scale-info={ version="2.11", default-features=false, features=["derive"] }
log ={ version="0.4.22", default-features=false }
scale-info={ version="2.11", default-features=false, features=["derive"] }
synedrion ={ git="https://github.com/entropyxyz/synedrion/", branch="hc/bump-deps-for-no-std-builds", default-features=false }
HCastano marked this conversation as resolved.
Show resolved Hide resolved

frame-benchmarking={ version="29.0.0", default-features=false, optional=true }
frame-support ={ version="29.0.0", default-features=false }
Expand Down
Loading
Loading