Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent key threshold dynamically #974

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

JesseAbram
Copy link
Member

@JesseAbram JesseAbram commented Aug 1, 2024

Related #941

  • Threshold stored with parent key
  • Reshare uses said storing

@JesseAbram JesseAbram marked this pull request as ready for review August 1, 2024 22:46
@JesseAbram JesseAbram requested review from ameba23 and HCastano August 1, 2024 22:46
Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - i don't know if the decision to move the jump start stuff to staking pallet was because it logically belongs there or because in needed to be there in order to mutate JumpStartProgress. But fine by me either way.

I still think we should treat changing the threshold with extreme caution until we have tested it a lot but as i said before i can't see why it wouldn't work just fine.

pallets/staking/src/lib.rs Outdated Show resolved Hide resolved
@JesseAbram
Copy link
Member Author

Looks good - i don't know if the decision to move the jump start stuff to staking pallet was because it logically belongs there or because in needed to be there in order to mutate JumpStartProgress. But fine by me either way.

It was the second one although since it is related to the parent key it may make sense in there but registry takes in staking so that means staking can't pull in registry or else we get circular dependency issues

I still think we should treat changing the threshold with extreme caution until we have tested it a lot but as i said before i can't see why it wouldn't work just fine.

Agreed

@JesseAbram JesseAbram merged commit 85a798b into master Aug 2, 2024
14 checks passed
@JesseAbram JesseAbram deleted the incorporate-t-and-n-dynamically branch August 2, 2024 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants