Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the aux gen protocol when resharing to a new signing committee #977

Merged
merged 12 commits into from
Aug 7, 2024

Conversation

ameba23
Copy link
Contributor

@ameba23 ameba23 commented Aug 2, 2024

Closes #976

When running the reshare protocol, we also need to re-generate aux info and store the aux info together with the new keyshare.

When running the refresh protocol (which is just a reshare with the parties not changing), we need to store the old aux info together with the new keyshare - as both are stored under the same key in the key-value db.

@ameba23 ameba23 marked this pull request as draft August 2, 2024 09:23
@ameba23 ameba23 changed the title Run the aux gen protocol when resharing to a new signing commitee Run the aux gen protocol when resharing to a new signing committee Aug 5, 2024
#[derive(Debug)]
pub enum DkgSubsession {
pub enum Subsession {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed this enum because it is no longer only used for DKG

@@ -20,7 +20,7 @@ tokio ={ version="1.39", features=["macros", "fs", "rt-multi-thread"
axum ={ version="0.7.5" }
entropy-shared ={ version="0.2.0", path="../shared" }
entropy-kvdb ={ version="0.2.0", path="../kvdb", default-features=false }
entropy-tss ={ version="0.2.0", path="../threshold-signature-server" }
entropy-tss ={ version="0.2.0", path="../threshold-signature-server", features = ["test_helpers"] }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but i needed this for testing locally

@ameba23 ameba23 marked this pull request as ready for review August 5, 2024 09:44
@ameba23 ameba23 requested review from JesseAbram and HCastano August 5, 2024 09:44
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍

CHANGELOG.md Outdated Show resolved Hide resolved
@ameba23 ameba23 merged commit f54a54f into master Aug 7, 2024
14 checks passed
@ameba23 ameba23 deleted the peg/store-aux-info branch August 7, 2024 05:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Both KeyShare and AuxInfo need to be stored on key reshare
3 participants