scopeId filter instead of scope type

env0 · Nov 24, 2023 · 855a93f · 855a93f
1 parent 8186b6f
commit 855a93f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/client/configuration_variable.go b/client/configuration_variable.go
@@ -113,7 +113,7 @@ func (client *ApiClient) ConfigurationVariablesByScope(scope Scope, scopeId stri
 	// The API returns variables of upper scopes. Filter them out.
 	var filteredVariables []ConfigurationVariable
 	for _, variable := range result {
-		if scope == variable.Scope {
+		if scopeId == variable.ScopeId {
 			filteredVariables = append(filteredVariables, variable)
 		}
 	}

diff --git a/client/configuration_variable_test.go b/client/configuration_variable_test.go
@@ -45,6 +45,7 @@ var _ = Describe("Configuration Variable", func() {
 		Value:          "ignore",
 		OrganizationId: organizationId,
 		Scope:          ScopeTemplate,
+		ScopeId:        "scope-id",
 	}
 
 	Describe("ConfigurationVariable", func() {
@@ -260,7 +261,7 @@ var _ = Describe("Configuration Variable", func() {
 	})
 
 	Describe("ConfigurationVariablesByScope", func() {
-		scopeId := "scope-id"
+		scopeId := mockTemplateConfigurationVariable.ScopeId
 
 		var returnedVariables []ConfigurationVariable
 		mockVariables := []ConfigurationVariable{mockTemplateConfigurationVariable}