Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add a manual approval step for a release #725

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

closes #723

Solution

Added a step to request for another approval before release.

@TomerHeber
Copy link
Collaborator Author

I need assistance to test this.

@@ -20,6 +20,7 @@ env:

jobs:
goreleaser:
environment: release
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need help to configure the environment.

Copy link
Contributor

@yaronya yaronya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMK how can I help

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Oct 18, 2023
@TomerHeber TomerHeber merged commit 35f5cd9 into main Oct 19, 2023
@TomerHeber TomerHeber deleted the chore-manual-approval-#723 branch October 19, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore github-actions ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: add a manual approval step for a release
2 participants