Fix: integration test 025 is not isolated

[sagilaufer1992]

Issue & Steps to Reproduce / Feature Request

test 025_notifications uses all_notifications, and it fetches data from other tests, such as 017_notification, that may become unavailable during test 025's run.

Solution

make the test rely solely on its own data

QA done

ran the test locally to make sure it works on its own. deliberately failing it is much harder, didn't happen sporadically (that we caught) until a few days prior to the PR

[avnerenv0]

why not just use

locals {
  test_notification_1_name = "notification123-${random_string.random.result}-1"
}

data "env0_notification" "my_notification" {
  name = locals.test_notification_1_name
}

here?

[sagilaufer1992]

we wish to see that the all_notifications works as expected too, so I suggest we utilize its data, so if it got broken for some reason the test will fail

[chpl]

agree with @avnerenv0 .
can be replaced with post condition on the all_notifications data

    postcondition {
      condition     = contains(self.names, local.test_notification_1_name)
      error_message = "One of the notifications not found"
    }

[sagilaufer1992]

0c08f76

used the resource name, and used output for the all_notifications verification, that it got one of the notifications