Feat: add new OIDC credentials creation and assigment (AWS Resource) #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Nov 27, 2023
| @@ -100,6 +100,7 @@ func Provider(version string) plugin.ProviderFunc { | |||
| "env0_template": resourceTemplate(), | |||
| "env0_ssh_key": resourceSshKey(), | |||
| "env0_aws_credentials": resourceAwsCredentials(), | |||
| "env0_aws_oidc_credentials": resourceAwsOidcCredentials(), | |||
There was a problem hiding this comment.
As discussed. A new resource is created (same for GCP and Azure).
| @@ -0,0 +1,2 @@ | |||
| terraform import env0_aws_oidc_credentials.by_id d31a6b30-5f69-4d24-937c-22322754934e | |||
| terraform import env0_aws_oidc_credentials.by_name "credentials name" | |||
There was a problem hiding this comment.
Look like you are missing an empty line here
| } | ||
|
|
||
| func resourceAwsOidcCredentialsUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { | ||
| apiClient := meta.(client.ApiClientInterface) |
There was a problem hiding this comment.
Can you extract the part before you put value in request into a function? I see it's the same code in resourceAwsOidcCredentialsUpdate and in resourceAwsOidcCredentialsCreate
fixed. |
Yossi-kerner
approved these changes
Nov 28, 2023
github-actions
bot
added
ready to merge
TomerHeber
added a commit
that referenced
this pull request
Dec 13, 2023
TomerHeber
added a commit
that referenced
this pull request
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Part of #743.