Feat: support 'Enable Remote Apply' flag on environment settings #763
Conversation
| @@ -118,6 +118,7 @@ type Environment struct { | |||
| BlueprintId string `json:"blueprintId" tfschema:"-"` | |||
| IsRemoteBackend *bool `json:"isRemoteBackend" tfschema:"-"` | |||
| IsArchived *bool `json:"isArchived" tfschema:"-"` | |||
| IsRemoteApplyEnabled bool `json:"isRemoteApplyEnabled"` | |||
There was a problem hiding this comment.
in golang, this defaults to false.
I don't need it to be a pointer because the schema defaults to 'false'.
(unfortunately, defaults were not used in the early days of the provider which caused a lot of challenges).
| Type: schema.TypeBool, | ||
| Description: "enables remote apply when set to true (defaults to false). Can only be enabled when is_remote_backend and approve_plan_automatically are enabled. Can only enabled for an existing environment", | ||
| Optional: true, | ||
| Default: false, |
There was a problem hiding this comment.
this is important...
| @@ -519,6 +525,11 @@ func validateTemplateProjectAssignment(d *schema.ResourceData, apiClient client. | |||
| func resourceEnvironmentCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { | |||
| apiClient := meta.(client.ApiClientInterface) | |||
|
|
|||
| isRemoteApplyEnabled := d.Get("is_remote_apply_enabled").(bool) | |||
There was a problem hiding this comment.
is_remote_apply_enabled cannot be set to true during environment creation.
| isRemoteApplyEnabled := d.Get("is_remote_apply_enabled").(bool) | ||
| isRemotedBackend := d.Get("is_remote_backend").(bool) | ||
| approvePlanAutomatically := d.Get("approve_plan_automatically").(bool) | ||
| if isRemoteApplyEnabled && (!isRemotedBackend || !approvePlanAutomatically) { |
There was a problem hiding this comment.
is_remote_apply_enabled may only be true when the others are true.
| testCase := resource.TestCase{ | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: resourceConfigCreate(resourceType, resourceName, map[string]interface{}{ |
There was a problem hiding this comment.
regular creation.
| ), | ||
| }, | ||
| { | ||
| Config: resourceConfigCreate(resourceType, resourceName, map[string]interface{}{ |
There was a problem hiding this comment.
updated and set is_remote_apply_enabled to true.
| "name": environment.Name, | ||
| "project_id": environment.ProjectId, | ||
| "template_id": templateId, | ||
| "is_remote_backend": !*environment.IsRemoteBackend, |
There was a problem hiding this comment.
making this false to test the error use-case.
| } | ||
|
|
||
| runUnitTest(t, testCase, func(mock *client.MockApiClientInterface) { | ||
| gomock.InOrder( |
There was a problem hiding this comment.
alot of mocks... it's just how the provider works... /:
| @@ -1391,6 +1503,22 @@ func TestUnitEnvironmentResource(t *testing.T) { | |||
| } | |||
|
|
|||
| testValidationFailures := func() { | |||
| t.Run("create environment with is_remote_apply_enabled set to 'true'", func(t *testing.T) { | |||
There was a problem hiding this comment.
test error on creation when is_remote_apply_enabled is set to true.
| @@ -45,6 +45,7 @@ func resourceCustomRole() *schema.Resource { | |||
| "VIEW_PROVIDERS", | |||
| "VIEW_ENVIRONMENT", | |||
| "ASSIGN_ROLE_ON_ENVIRONMENT", | |||
| "EDIT_ALLOW_REMOTE_APPLY", | |||
There was a problem hiding this comment.
added the new custom role.
the provider doesn't check for rbac. That's a backend feature.
github-actions
bot
added
ready to merge
Issue & Steps to Reproduce / Feature Request
resolves #761
Solution