Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add new OIDC credentials creation and assigment (Azure Resource) #769

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Feat: add new OIDC credentials creation and assigment (Azure Resource) #769

merged 3 commits into from
Dec 17, 2023

Conversation

TomerHeber
Copy link
Collaborator

Solution

Part of #743.

  1. Added a new Azure OIDC credentials resource.
  2. Added unit tests.
  3. Added acceptance tests.
  4. Added integration tests.
  5. Added examples.

@TomerHeber TomerHeber self-assigned this Dec 12, 2023
@TomerHeber TomerHeber requested a review from yaronya December 12, 2023 15:36
@TomerHeber
Copy link
Collaborator Author

ignore PR Labeler / pr-labeler failure - fixed in a different PR.

Yossi-kerner
Yossi-kerner approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@Yossi-kerner Yossi-kerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Dec 17, 2023
@TomerHeber TomerHeber merged commit cec07ec into main Dec 17, 2023
5 checks passed
@TomerHeber TomerHeber deleted the feat-azure-oidc-#755 branch December 17, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yossi-kerner Yossi-kerner Yossi-kerner approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client examples feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomerHeber @Yossi-kerner