Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: cannot change template id, instead return an error #770

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Feat: cannot change template id, instead return an error #770

merged 1 commit into from
Dec 18, 2023

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #766

Solution

  1. Removed forcenew when template id is changed.
  2. Return an error if template id is set, and is then modified.
  3. Add an acceptance test to validate that the plan will fail.

@TomerHeber TomerHeber requested a review from yaronya December 18, 2023 16:59
@TomerHeber TomerHeber self-assigned this Dec 18, 2023
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Dec 18, 2023
@TomerHeber TomerHeber merged commit 936dbc4 into main Dec 18, 2023
7 checks passed
@TomerHeber TomerHeber deleted the feat-template-id-change-#766 branch December 18, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronya yaronya yaronya approved these changes

Assignees

@TomerHeber TomerHeber

Labels
feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: env0 should return 400 when trying to update template ID inside env0_environment resource
2 participants
@TomerHeber @yaronya