Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add new OIDC credentials creation and assigment (gcp resource) #782

Merged
merged 6 commits into from
Jan 14, 2024
Merged

Feat: add new OIDC credentials creation and assigment (gcp resource) #782

merged 6 commits into from
Jan 14, 2024

Conversation

TomerHeber
Copy link
Collaborator

Solution

Part of #743.

  1. Refactoring to reduce code duplication.
  2. Added gcp oidc resource and data source.
  3. Added acceptance tests.
  4. Added integration tests.
  5. Updated and added examples.

@TomerHeber TomerHeber self-assigned this Jan 9, 2024
@TomerHeber TomerHeber requested a review from yaronya January 9, 2024 23:44
Yossi-kerner
Yossi-kerner reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@Yossi-kerner Yossi-kerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great left some small comments and questions

client/cloud_credentials.go Show resolved Hide resolved
client/cloud_credentials.go Show resolved Hide resolved
env0/data_oidc_credentials_test.go Show resolved Hide resolved
examples/data-sources/env0_azure_oidc_credentials/data-source.tf Outdated Show resolved Hide resolved
examples/data-sources/env0_gcp_oidc_credentials/data-source.tf Outdated Show resolved Hide resolved
Yossi-kerner
Yossi-kerner approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@Yossi-kerner Yossi-kerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jan 14, 2024
@TomerHeber TomerHeber merged commit fb6bde6 into main Jan 14, 2024
5 checks passed
@TomerHeber TomerHeber deleted the feat-add-new-gcp-oidc-#743 branch January 14, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yossi-kerner Yossi-kerner Yossi-kerner approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client examples feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomerHeber @Yossi-kerner