Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Organization Role assignments for Team #813

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Feat: Organization Role assignments for Team #813

merged 4 commits into from
Mar 27, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #807

Solution

  1. Added API calls.
  2. Added unit tests for API calls.
  3. Created a new resource.
  4. Added acceptance tests for the new resource.
  5. Added integration test for the resource.
  6. Added examples.

@TomerHeber TomerHeber self-assigned this Mar 25, 2024
@TomerHeber TomerHeber requested a review from yaronya March 26, 2024 12:45
sagydr
sagydr reviewed Mar 26, 2024
View reviewed changes
env0/resource_team_organization_assignment.go
Comment on lines +78 to +79
tflog.Warn(ctx, "Drift Detected: Terraform will remove id from state", map[string]interface{}{"id": d.Id()})
d.SetId("")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry can you explain these lines?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofcourse (:

They way to handle drifts in terraform provider is by resetting the "id" to an empty string.
Once "id" is removed, it will "recreate it"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Read command and reaching that code means assignment wasn't found among all organization assignments, so clearing the id will force it to be (re)created?
But why is it Drifted? the assignment isn't found in our DB, not in the tf state, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the tfstate but not in the backend.
So it will add it back to the backend.

If the user doesn't want that, he needs to remove it from the terraform file/state. (This will avoid drift).

sagydr
sagydr approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@sagydr sagydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Mar 27, 2024
@TomerHeber TomerHeber merged commit d2efd0c into main Mar 27, 2024
4 checks passed
@TomerHeber TomerHeber deleted the feat-org-role-team-assigment-#807 branch March 27, 2024 13:14
@razbensimon razbensimon mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagydr sagydr sagydr approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client examples feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organization Role assignments for Team
2 participants
@TomerHeber @sagydr