Fix: Cloudformation Template - Forcing refresh of a TerraformVersion … #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Apr 3, 2024
| @@ -39,7 +39,7 @@ func main() { | |||
| } else { | |||
| success, err := runTest(testName, destroyMode != "NO_DESTROY") | |||
| if !success { | |||
| log.Fatalln("Halting due to test failure:", err) | |||
| log.Fatalf("Halting due to test '%s' failure: %s\n", testName, err.Error()) | |||
There was a problem hiding this comment.
unrelated - but was requested to get fixed.
TomerHeber
commented
Apr 3, 2024
|
|
||
| // If this value isn't set, ignore whatever is returned from the response. | ||
| // This helps avoid drifts when defaulting to 'opentofu' for new 'terragrunt' templates, and 'terraform' for existing 'terragrunt' templates. | ||
| // 'template.TerragruntTfBinary' field is set to 'omitempty'. Therefore, the state isn't modified if `template.TerragruntTfBinary` is an empty string. | ||
| if terragruntTfBinary == "" { | ||
| template.TerragruntTfBinary = "" | ||
| } | ||
| // Same explanation as above. |
There was a problem hiding this comment.
This is a mitigation. But I believe it will solve the issue. (As I'm unsure why it's happening to the user).
yaronya
approved these changes
Apr 5, 2024
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…field
Issue & Steps to Reproduce / Feature Request
fixes #818
Solution
I'm unsure why it's occurring. But I applied a mitigation.
Tests seem to pass.