Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add support for namespace in env0_environment resource #827

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #826

Solution

  1. Added the k8s_namespace to the schema and API structures.
  2. Updated acceptance tests.

Type: schema.TypeString,
Description: "kubernetes (or helm) namespace to be used. If modified deletes current environment and creates a new one",
Optional: true,
ForceNew: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a way to update it in the UI.
Therefore, setting to ForceNew.

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Apr 17, 2024
@TomerHeber TomerHeber merged commit a79eb73 into main Apr 17, 2024
8 checks passed
@TomerHeber TomerHeber deleted the feat-add-k8s_namespace-#826 branch April 17, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-client feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for namespace in env0_environment resource
2 participants