Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: enhance approval policy #833

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Feat: enhance approval policy #833

merged 4 commits into from
Apr 24, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #822

Solution

  1. Update API to use delete assignment by an id.
  2. Update resource code to call the new API.
  3. Updated unit tests.
  4. Updated acceptance tests.
  5. Added support for BLUEPRINT option.

@TomerHeber TomerHeber changed the title Feat enhance approval policy #822 Feat: enhance approval policy Apr 21, 2024
Yossi-kerner
Yossi-kerner approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Yossi-kerner Yossi-kerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@github-actions github-actions bot added the ready to merge PR approved - can be merged once the PR owner is ready label Apr 24, 2024
@TomerHeber TomerHeber merged commit cdaed47 into main Apr 24, 2024
4 checks passed
@TomerHeber TomerHeber deleted the feat-enhance-approval-policy-#822 branch April 24, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yossi-kerner Yossi-kerner Yossi-kerner approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support enhanced approval policies and custom flows
2 participants
@TomerHeber @Yossi-kerner