Feat: add a retry mechanism for getSshKeyByName #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
May 12, 2024
| @@ -62,26 +64,28 @@ func dataSshKeyRead(ctx context.Context, d *schema.ResourceData, meta interface{ | |||
| func getSshKeyByName(name interface{}, meta interface{}) (*client.SshKey, error) { | |||
| apiClient := meta.(client.ApiClientInterface) | |||
|
|
|||
There was a problem hiding this comment.
nothing much really changed here... the same code is just inside a retry mechanism.
TomerHeber
commented
May 12, 2024
| return nil, fmt.Errorf("ssh key with name %v not found", name) | ||
| } | ||
| if len(sshKeysByName) > 1 { | ||
| return nil, backoff.Permanent(fmt.Errorf("found multiple ssh keys with name: %s. Use id instead or make sure ssh key names are unique %v", name, sshKeysByName)) |
There was a problem hiding this comment.
added backoff.Permanent (means fail without retrying...).
yaronya
approved these changes
May 12, 2024
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #848
Solution