Feat: add API calls for configuration set #853
Conversation
client/configuration_set.go
Outdated
|
|
||
| if err := client.http.Get("/configuration", map[string]string{ | ||
| "setId": setId, | ||
| "organizationId": organizationId, |
There was a problem hiding this comment.
don't send the organizationId it will return both the variables of the set and the organization...
You should send only the setId
There was a problem hiding this comment.
got it! thanks!
client/configuration_set.go
Outdated
| func (client *ApiClient) ConfigurationSets(scope string, scopeId string) ([]ConfigurationSet, error) { | ||
| var result []ConfigurationSet | ||
| var err error | ||
|
|
||
| if scope == "organization" { | ||
| scopeId, err = client.OrganizationId() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
|
|
||
| if err := client.http.Get("/configuration-sets", map[string]string{ | ||
| "scope": scope, | ||
| "scopeId": scopeId, | ||
| "includeHigherScopes": "false", | ||
| }, &result); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return result, nil |
There was a problem hiding this comment.
I'm not sure why you need this API...
In the FE we want to list the sets
do you plan to add all_sets data ?
There was a problem hiding this comment.
sure I can remove it for now.
client/configuration_set.go
Outdated
| } | ||
|
|
||
| type ConfigurationSet struct { | ||
| Id string `json:"id"` |
There was a problem hiding this comment.
the return also contain the name and the description
There was a problem hiding this comment.
yes I know. Not really needed. But I'll add it.
yes. |
github-actions
bot
added
ready to merge
Solution
Part of #829