Chore: add environment import api client #855
Conversation
client/api_client.go
Outdated
TomerHeber
force-pushed
the
chore-add-environment-import-resource
branch
from
9616927 to
c708bec
Compare
TomerHeber
changed the title
alonnoga
changed the title
client/environment_import.go
Outdated
| Name string `json:"name"` | ||
| Value string `json:"value"` | ||
| IsSensitive bool `json:"isSensitive"` | ||
| Type string `json:"tyoe"` // string or JSON |
client/environment_import.go
Outdated
| } | ||
|
|
||
| type GitConfig struct { | ||
| Path string `json:"path"` |
There was a problem hiding this comment.
if it's empty and you don't want to pass an empty string you may add omitempty
client/environment_import.go
Outdated
|
|
||
| type GitConfig struct { | ||
| Path string `json:"path"` | ||
| Revision string `json:"revision"` |
There was a problem hiding this comment.
if it's empty and you don't want to pass an empty string you may add omitempty
client/environment_import_test.go
Outdated
| result, _ = apiClient.EnvironmentImportGet(mockEnvironmentImport.Id) | ||
| }) | ||
|
|
||
| It("Should get organization id", func() { |
client/environment_import_test.go
Outdated
| }) | ||
|
|
||
| It("Should get organization id", func() { | ||
| organizationIdCall.Times(1) |
There was a problem hiding this comment.
move the times(1) to the BeforeEach.
This It isn't needed.
There was a problem hiding this comment.
is it important to even test this is called? if the mock is missing the test fails
client/environment_import_test.go
Outdated
| var result *EnvironmentImport | ||
| var mockedResponse EnvironmentImport | ||
| BeforeEach(func() { | ||
| mockOrganizationIdCall(organizationId) |
client/environment_import_test.go
Outdated
| result, _ = apiClient.EnvironmentImportUpdate(mockEnvironmentImport.Id, &payload) | ||
| }) | ||
|
|
||
| It("Should send PUT request with environment import ID and expected payload", func() { |
There was a problem hiding this comment.
add the times(1) to the httpCall... the It can be removed.
| @@ -2,44 +2,44 @@ package client | |||
|
|
|||
| type EnvironmentImport struct { | |||
There was a problem hiding this comment.
omit empty isn't needed here. This is just a response (doesn't matter to in golang).
|
|
||
| type Variable struct { | ||
| Name string `json:"name"` | ||
| Value string `json:"value,omitempty"` |
There was a problem hiding this comment.
is omitempty needed here?
There was a problem hiding this comment.
All of what this resource does is create an entity that we'll use to auto fill a form in the UI
So I want them to be able to just specify variables without values ( and leave their value as empty in the UI for them to manually fill in )
This is very unlikely though I can remove it, its not important
github-actions
bot
added
ready to merge
This reverts commit e37247b
This reverts commit e37247b
Issue & Steps to Reproduce / Feature Request
part of #856
Solution
Add environment import CRUD to api client