-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add an environment import resource #858
Conversation
@@ -1161,7 +1161,8 @@ func getEnvironmentById(environmentId string, meta interface{}) (client.Environm | |||
return environment, nil | |||
} | |||
|
|||
func resourceEnvironmentImport(ctx context.Context, d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { | |||
// a function to import an environment resource not to be consufed with the "environment import" resource (which is a different resource) | |||
func resourceEnvironmentImporter(ctx context.Context, d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a function that handles importing environment resources ( not environment import resource )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I just had to think twice about it that's all
|
||
// should not actually delete the environment import | ||
func resourceEnvironmentImportDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this is correct. Can you please explain why you want to create a drift?
If it's really required, perhaps add an explanation to the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're creating a feature to make onboarding existing stacks to env0 easier
We don't expect people to use this resource directly we just generate code that uses it ( so we don't expect them to commit this code to git, and manage it )
All of what this resource does is populate a wizard in our UI
I'll add more info in the comment
This reverts commit 3a475d6
This reverts commit 3a475d6
Issue & Steps to Reproduce / Feature Request
part of #856