Feat: importing templateless environment causes the configuration to … #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLRabinowitz
approved these changes
Jun 6, 2024
Comment on lines
+443
to
+444
| // This is not true for imports - because the shcema is empty irrespective in that case. | ||
| if !isImport { |
There was a problem hiding this comment.
Is this condition necessary? If the schema is empty anyway
What would be the effect of removing this condition?
There was a problem hiding this comment.
it will not import terraform_version properly.
If the schema is empty (which it is in import), it will remove these values from the struct, afterwards when updates the schema based on the steuct, terraform_version will not be set.
This occurred to me running the test. So I added this condition.
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…be unplannable
Issue & Steps to Reproduce / Feature Request
resolves #865
Solution