Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add variable set support for environment schema #878

Merged
merged 7 commits into from
Jun 19, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #829

Solution

  1. Added 'variable_sets' to the schema (a list of ids).
  2. Implemented handling in environment resource for "read, update and create".
  3. Added an acceptance test.
  4. Update an integration test to cover the use-case.

@TomerHeber TomerHeber requested a review from GiliFaroEnv0 June 18, 2024 23:15
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!
add a suggestion for the tests

@@ -224,6 +239,8 @@ resource "env0_environment" "workflow-environment" {
value = "v1"
}

variable_sets = [env0_variable_set.variable_set.id]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add in the secound run a different set that way we also check the unassign logic

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@github-actions github-actions bot added the ready to merge PR approved - can be merged once the PR owner is ready label Jun 19, 2024
@TomerHeber TomerHeber merged commit 864e53f into main Jun 19, 2024
3 of 4 checks passed
@TomerHeber TomerHeber deleted the feat-variable-set-environment-#829 branch June 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-client feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to new ConfigurationSet functionality
2 participants