Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add data source for env0_variable_set #897

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Feat: add data source for env0_variable_set #897

merged 5 commits into from
Jul 30, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #892

Solution

  1. Added the new data resource.
  2. Added a required API call.
  3. Added unit tests for the new API call.
  4. Added acceptance tests for the new data source.
  5. Added a couple of harness tests.
  6. Added examples.

@TomerHeber TomerHeber self-assigned this Jul 18, 2024
@TomerHeber TomerHeber requested a review from yaronya July 21, 2024 17:53
@yaronya yaronya requested a review from tomporat247 July 29, 2024 13:37
tomporat247
tomporat247 approved these changes Jul 29, 2024
View reviewed changes
env0/data_variable_set.go
Description: "the name of the variable set",
Required: true,
},
"scope": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think calling this creationScope is clearer, will also match our API

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could do "creation_scope".
However, in all other places in the provider, it's scope.
So I prefer to keep it aligned.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I already approved regardless 😄

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jul 29, 2024
@TomerHeber TomerHeber merged commit bc149f5 into main Jul 30, 2024
5 checks passed
@TomerHeber TomerHeber deleted the feat-ds-variable-set-#892 branch July 30, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomporat247 tomporat247 tomporat247 approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client examples feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add data source for env0_variable_set
2 participants
@TomerHeber @tomporat247