Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: importing a non-existent environment show an 'Authentication err… #901

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix: importing a non-existent environment show an 'Authentication err… #901

merged 1 commit into from
Jul 22, 2024

Conversation

TomerHeber
Copy link
Collaborator

…or' in variable sets instead

Issue & Steps to Reproduce / Feature Request

fixes #900

Solution

  1. Fixed the error check.
  2. Added an acceptance test for this use-case.

@TomerHeber TomerHeber self-assigned this Jul 21, 2024
@TomerHeber TomerHeber requested a review from yaronya July 21, 2024 17:50
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jul 22, 2024
@TomerHeber TomerHeber merged commit 5eeae08 into main Jul 22, 2024
7 checks passed
@TomerHeber TomerHeber deleted the bug-import-env-not-found-#900 branch July 22, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RLRabinowitz RLRabinowitz RLRabinowitz approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Importing a non-existent environment show an "Authentication error" in variable sets instead
2 participants
@TomerHeber @RLRabinowitz