Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: gitlab_project_id always shows drift #917

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Feat: gitlab_project_id always shows drift #917

merged 3 commits into from
Jul 30, 2024

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Jul 30, 2024 •
edited
Loading

Issue & Steps to Reproduce / Feature Request

fixes #916

Solution

  1. Added gitlabProjectId to template response.
  2. Fixed acceptance tests.

@TomerHeber TomerHeber self-assigned this Jul 30, 2024
@TomerHeber TomerHeber changed the title Feat gitlab drift #916 Feat: gitlab_project_id always shows drift Jul 30, 2024
@TomerHeber TomerHeber requested a review from yaronya July 30, 2024 21:45
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jul 30, 2024
@TomerHeber TomerHeber merged commit f1d24fc into main Jul 30, 2024
6 checks passed
@TomerHeber TomerHeber deleted the feat-gitlab-drift-#916 branch July 30, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@away168 away168 away168 approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitlab_project_id always shows drift
2 participants
@TomerHeber @away168