Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: support new ansible template type #930

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Feat: support new ansible template type #930

merged 3 commits into from
Aug 11, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #926

Solution

  1. Updated the template API structs.
  2. Updated the schema and implemented support.
  3. Updated acceptance tests.
  4. Added a harness test.
  5. Some other misc changes (part of linting/bug fixes effort).

@TomerHeber TomerHeber self-assigned this Aug 8, 2024
Wassap124
Wassap124 reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@Wassap124 Wassap124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed that we also accept latest version 🙏

client/template.go Show resolved Hide resolved
env0/data_template.go Show resolved Hide resolved
env0/resource_template.go Outdated Show resolved Hide resolved
@Wassap124
Copy link
Contributor

Support Ansible in terraform provider

@TomerHeber TomerHeber requested a review from Wassap124 August 11, 2024 12:41
Wassap124
Wassap124 approved these changes Aug 11, 2024
View reviewed changes
Copy link
Contributor

@Wassap124 Wassap124 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 👍

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Aug 11, 2024
@TomerHeber TomerHeber merged commit 6ceee88 into main Aug 11, 2024
10 checks passed
@TomerHeber TomerHeber deleted the feat-support-ansible-template-#926 branch August 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wassap124 Wassap124 Wassap124 approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new ansible template type
2 participants
@TomerHeber @Wassap124