-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: fetch Github Installation Id from env0 #934
Conversation
client/api_client.go
Outdated
@@ -166,6 +166,7 @@ type ApiClientInterface interface { | |||
CloudAccountDelete(id string) error | |||
CloudAccount(id string) (*CloudAccount, error) | |||
CloudAccounts() ([]CloudAccount, error) | |||
VscToken(vcsType string, repository string) (*VscToken, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vcs not Vsc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix that. Thanks!
"repository": { | ||
Type: schema.TypeString, | ||
Description: "the name of the repository", | ||
Required: true, | ||
}, | ||
"github_installation_id": { | ||
Type: schema.TypeInt, | ||
Description: "the github installation id", | ||
Computed: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why both? "repository" is parameter and "github installation id" is the return type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct. One is an input, the other is computed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, approved with small questions
Issue & Steps to Reproduce / Feature Request
resolves #928
Solution