Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: fetch Github Installation Id from env0 #934

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Aug 14, 2024

Issue & Steps to Reproduce / Feature Request

resolves #928

Solution

  1. Added the API call.
  2. Added unit tests for API call.
  3. Added the data source.
  4. Added acceptance tests for the data source.
  5. Added harness test for the data source.
  6. Added an example of the data source.

@@ -166,6 +166,7 @@ type ApiClientInterface interface {
CloudAccountDelete(id string) error
CloudAccount(id string) (*CloudAccount, error)
CloudAccounts() ([]CloudAccount, error)
VscToken(vcsType string, repository string) (*VscToken, error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vcs not Vsc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix that. Thanks!

Comment on lines +18 to +27
"repository": {
Type: schema.TypeString,
Description: "the name of the repository",
Required: true,
},
"github_installation_id": {
Type: schema.TypeInt,
Description: "the github installation id",
Computed: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why both? "repository" is parameter and "github installation id" is the return type?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. One is an input, the other is computed.

Copy link
Contributor

@sagydr sagydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, approved with small questions

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Aug 21, 2024
@TomerHeber TomerHeber merged commit 322bbc6 into main Aug 21, 2024
4 checks passed
@TomerHeber TomerHeber deleted the feat-github-installation-id-#928 branch August 21, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch Github Installation Id from env0
2 participants