Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: allow is_remote_apply on env0_environment creation #936

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Feat: allow is_remote_apply on env0_environment creation #936

merged 2 commits into from
Aug 21, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #933

Solution

  1. Removed the 'if condifition' causing this to fail.
  2. Updated acceptance tests.
  3. Minor misc changes.

@TomerHeber TomerHeber requested a review from yaronya August 16, 2024 12:58
@TomerHeber TomerHeber self-assigned this Aug 16, 2024
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Aug 21, 2024
@TomerHeber TomerHeber merged commit cff9b13 into main Aug 21, 2024
4 checks passed
@TomerHeber TomerHeber deleted the feat-allow-remote-apply-#933 branch August 21, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronya yaronya yaronya approved these changes

Assignees

@TomerHeber TomerHeber

Labels
feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow is_remote_apply on env0_environment creation
2 participants
@TomerHeber @yaronya