Feat: stop requiring gitlab_project_id for gitlab templates #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Aug 25, 2024
| default: | ||
| return fmt.Errorf("unhandled type %s", putPayload.Type) | ||
| } | ||
|
|
||
| vcsCounter := 0 |
There was a problem hiding this comment.
removed this because this may cause some issues. Not clear how to resolve.
Schema validation is a nice to have. Instead BE will error on this.
TomerHeber
commented
Aug 25, 2024
| @@ -711,45 +707,6 @@ func TestUnitEnvironmentDiscoveryConfigurationResource(t *testing.T) { | |||
| runUnitTest(t, testCase, func(mock *client.MockApiClientInterface) {}) | |||
| }) | |||
|
|
|||
| t.Run("error: no vcs set", func(t *testing.T) { | |||
There was a problem hiding this comment.
removed relevant tests.
yaronya
approved these changes
Aug 26, 2024
| @@ -143,10 +142,10 @@ func resourceEnvironmentDiscoveryConfiguration() *schema.Resource { | |||
| Optional: true, | |||
| }, | |||
| "gitlab_project_id": { | |||
| @@ -152,14 +153,13 @@ func getTemplateSchema(prefix string) map[string]*schema.Schema { | |||
| Type: schema.TypeString, | |||
| Description: "the git token id to be used", | |||
| Optional: true, | |||
| ConflictsWith: allVCSAttributesBut("token_id", "gitlab_project_id", "is_azure_devops", "path"), | |||
| ConflictsWith: allVCSAttributesBut("token_id", "is_azure_devops", "path"), | |||
| }, | |||
| "gitlab_project_id": { | |||
env0/configuration_template.go
Outdated
| RequiredWith: []string{"token_id"}, | ||
| Type: schema.TypeInt, | ||
| Description: "the project id of the relevant repository (deprecated)", | ||
| Deprecated: "'repository' is used instead", |
There was a problem hiding this comment.
Text should be changed
We should use "project id is now auto-fetched from the repository URL"
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #940
Solution