Chore: move env test is flaky - use never deployed env #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chpl
changed the title
yarivg
approved these changes
Aug 26, 2024
| @@ -55,7 +55,7 @@ resource "env0_environment" "example" { | |||
| depends_on = [env0_template_project_assignment.assignment] | |||
There was a problem hiding this comment.
yes. tomer just added the move part here
There was a problem hiding this comment.
I think the original purpose of the test was to test different types / settings of environments, and here there was an attempt to kill 2 birds with one stone by testing both regular deployment and move environment. so I think it is still needed for the original purpose
github-actions
bot
added
the
ready to merge
chpl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
the test is flaky - often fails with
(was added in #939)
Solution
use never deployed environment