Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: is_remote_apply_enabled not being sent to BE #945

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Feat: is_remote_apply_enabled not being sent to BE #945

merged 1 commit into from
Aug 28, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #942

Solution

  1. Added isRemoteApplyEnabled to the create structs.
  2. Updated schema text.
  3. Added a new test.

@TomerHeber TomerHeber self-assigned this Aug 28, 2024
tomer-landesman
tomer-landesman approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@tomer-landesman tomer-landesman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Aug 28, 2024
@TomerHeber TomerHeber merged commit f64b40d into main Aug 28, 2024
7 checks passed
@TomerHeber TomerHeber deleted the feat-is_remote_apply-#942 branch August 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomer-landesman tomer-landesman tomer-landesman approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_remote_apply_enabled not being sent to BE
2 participants
@TomerHeber @tomer-landesman