Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: variable set assignment drifts with parent projects #961

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Fix: variable set assignment drifts with parent projects #961

merged 4 commits into from
Oct 7, 2024

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Oct 7, 2024 •
edited
Loading

Issue & Steps to Reproduce / Feature Request

fixes #960

Solution

  1. Filtered out assignments returned by inheritence (E.g. parent project), by using AssignmentScopeId.
  2. Updated acceptance tests.

/review

@TomerHeber TomerHeber self-assigned this Oct 7, 2024
@bot-env0 bot-env0 requested a review from a team October 7, 2024 13:11
GiliFaroEnv0
GiliFaroEnv0 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, you can remove some check

env0/resource_variable_set_assignment.go Outdated
Comment on lines 192 to 193
if !strings.EqualFold(apiConfigurationSet.AssignmentScope, assignmentSchema.Scope) {
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this check

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Oct 7, 2024
@TomerHeber TomerHeber merged commit 1209c07 into main Oct 7, 2024
4 checks passed
@TomerHeber TomerHeber deleted the fix-drift-variable-set-assignment-#960 branch October 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiliFaroEnv0 GiliFaroEnv0 GiliFaroEnv0 approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client fix provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug on resource env0_variable_set_assignment
2 participants
@TomerHeber @GiliFaroEnv0