Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: env0_environment resource - cannot re-enable vcs #963

Merged
merged 5 commits into from
Oct 27, 2024
Merged

Fix: env0_environment resource - cannot re-enable vcs #963

merged 5 commits into from
Oct 27, 2024

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Oct 10, 2024 •
edited by Wassap124
Loading

Issue & Steps to Reproduce / Feature Request

fixes #962

Solution

Modified the order of calls. Updating the template occurs first.

@TomerHeber TomerHeber self-assigned this Oct 10, 2024
@TomerHeber
Copy link
Collaborator Author

/review

@bot-env0 bot-env0 requested a review from a team October 10, 2024 14:24
@Wassap124
Copy link
Contributor

Wassap124 commented Oct 21, 2024 •
edited
Loading

can you add a test that validates the bug is resolved?

@TomerHeber
Copy link
Collaborator Author

can you add a test that validates the bug is resolved?

@Wassap124 - it's an excellent idea.
Unfortunatly, testing via acceptance test is not helpful.
I will have to add a harness test instead. I will check that option, and revert back.

@TomerHeber
Copy link
Collaborator Author

can you add a test that validates the bug is resolved?

@Wassap124 - it's an excellent idea. Unfortunatly, testing via acceptance test is not helpful. I will have to add a harness test instead. I will check that option, and revert back.

@Wassap124 - I have added a test to the harness tests. No issues (:

@TomerHeber TomerHeber requested a review from Wassap124 October 22, 2024 14:07
GiliFaroEnv0
GiliFaroEnv0 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Oct 27, 2024
@TomerHeber TomerHeber merged commit 4e6e7c1 into main Oct 27, 2024
5 checks passed
@TomerHeber TomerHeber deleted the fix-re-enable-vsc-#962 branch October 27, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiliFaroEnv0 GiliFaroEnv0 GiliFaroEnv0 approved these changes

@Wassap124 Wassap124 Awaiting requested review from Wassap124

Assignees

@TomerHeber TomerHeber

Labels
fix integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - env0_environment resource - cannot re-enable vcs
3 participants
@TomerHeber @Wassap124 @GiliFaroEnv0