Fix: env0_variable_set_assignment 404, Error: failed to unassign vari… #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able sets: 404 Not Found: Configuration Set "..." is not assigned to project.
|
/review |
TomerHeber
commented
Oct 30, 2024
| @@ -61,6 +61,11 @@ func TestUnitVariableSetAssignmentResource(t *testing.T) { | |||
| AssignmentScope: scope, | |||
| AssignmentScopeId: scopeId, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
added this use case: this should be filtered out.
(Which mean the test outcome shouldn't change).
yaronya
approved these changes
Oct 30, 2024
github-actions
bot
added
ready to merge
|
thank you @yaronya for the quick review (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able sets: 404 Not Found: Configuration Set "..." is not assigned to project.
Issue & Steps to Reproduce / Feature Request
fixes #966
Solution
Modified the filter to check scopeId instead of scope.