Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration tests templates must enforce terraform_tf_binary #977

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

onhate
Copy link
Contributor

@onhate onhate commented Nov 13, 2024

Issue & Steps to Reproduce / Feature Request

A change on env0's API requires to enforce the terraform_tf_binary when terraform_version is specified.

Fixes #975

Solution

Enforce terraform_tf_binary

@razbensimon
Copy link
Contributor

FYI @TomerHeber

@razbensimon razbensimon merged commit e9c0422 into env0:main Nov 14, 2024
3 of 5 checks passed
@TomerHeber
Copy link
Collaborator

Hi @razbensimon - you shouldn't have merged it since tests are failing.
But it's alright... I'll fix it later in the week.

@razbensimon
Copy link
Contributor

How did it let me? @TomerHeber
it ran a CI test. Where did I miss it?

@TomerHeber
Copy link
Collaborator

@razbensimon - not sure... no worries. I'll check it later. I might be mistaken.

@razbensimon
Copy link
Contributor

razbensimon commented Nov 14, 2024

@TomerHeber I afraid it may cause env0 pipeline to be blocked (we run those tests). I am checking..
so maybe we should revert now

@TomerHeber
Copy link
Collaborator

@razbensimon - running a dummy PR to confirm
#978

if it passes we're good.

@TomerHeber
Copy link
Collaborator

@razbensimon - looks like it passed. So false alarm. I was probably looking at an old failure.

@razbensimon
Copy link
Contributor

razbensimon commented Nov 14, 2024

yes just confirmed too.
from env0 pipeline:

2024/11/14 18:36:18 Completed successfully terraform [apply -auto-approve -var second_run=0] in 004_template
2024/11/14 18:36:52 Completed successfully terraform [apply -auto-approve -var second_run=1] in 012_environment

Thanks for checking too! @TomerHeber

@onhate onhate deleted the fix-integration-tests-004 branch November 15, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Not possible to use OpenTofu as backend binary for Terragrunt
3 participants