Feat: resource env0_environment - add support to change template_id #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/review |
TomerHeber
commented
Dec 21, 2024
| @@ -382,13 +381,6 @@ func resourceEnvironment() *schema.Resource { | |||
| Optional: true, | |||
| }, | |||
| }, | |||
| CustomizeDiff: customdiff.ValidateChange("template_id", func(ctx context.Context, oldValue, newValue, meta interface{}) error { | |||
There was a problem hiding this comment.
this blocked changing template_id...
TomerHeber
commented
Dec 21, 2024
| @@ -736,7 +728,7 @@ func shouldDeploy(d *schema.ResourceData) bool { | |||
| } | |||
| } | |||
|
|
|||
| return d.HasChanges("revision", "configuration", "sub_environment_configuration", "variable_sets") | |||
| return d.HasChanges("revision", "configuration", "sub_environment_configuration", "variable_sets", "template_id") | |||
There was a problem hiding this comment.
will call redeploy if template_id has changed.
TomerHeber
commented
Dec 21, 2024
| @@ -626,6 +643,12 @@ func TestUnitEnvironmentResource(t *testing.T) { | |||
| mock.EXPECT().ConfigurationSetsAssignments("ENVIRONMENT", environment.Id).Times(1).Return(nil, nil), | |||
| mock.EXPECT().Environment(environment.Id).Times(1).Return(environment, nil), | |||
| mock.EXPECT().ConfigurationVariablesByScope(client.ScopeEnvironment, environment.Id).Times(1).Return(client.ConfigurationChanges{}, nil), | |||
| mock.EXPECT().ConfigurationSetsAssignments("ENVIRONMENT", environment.Id).Times(2).Return(nil, nil), | |||
| mock.EXPECT().EnvironmentDeploy(environment.Id, deployRequest).Times(1).Return(client.EnvironmentDeployResponse{ | |||
There was a problem hiding this comment.
This is important - it shows that redeploy is called.
github-actions
bot
added
ready to merge
Co-authored-by: Liran Farage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #986
Solution