-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with future jasmine versions #367
Open
sgravrock
wants to merge
1
commit into
enzymejs:master
Choose a base branch
from
sgravrock:jasmine-3.6-deprecations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
67 changes: 67 additions & 0 deletions
67
packages/jasmine-enzyme/spec/customEqualityTesters--spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* eslint-disable global-require */ | ||
'use strict'; // eslint-disable-line | ||
|
||
const { shallow } = require('enzyme'); | ||
const React = require('react'); | ||
const jasmineEnzyme = require('../lib/index.js'); | ||
|
||
describe('Support for Jasmine custom equality testers', () => { | ||
function createMatcherFactory() { | ||
spyOn(jasmine, 'addMatchers'); | ||
jasmineEnzyme(); | ||
const addMatchersArgs = jasmine.addMatchers.calls | ||
.allArgs() | ||
.filter(args => args[0].toHaveState)[0]; | ||
return addMatchersArgs[0].toHaveState; | ||
} | ||
|
||
it('works with Jasmine <3.6', () => { | ||
const matcherFactory = createMatcherFactory(); | ||
const Fixture = require('./fixtures/toHaveState.fixture'); | ||
const wrapper = shallow(React.createElement(Fixture)); | ||
const util = { | ||
equals: (a, b, testers) => testers[0](a, b), | ||
}; | ||
const customEqualityTesters = [(a, b) => a.toString() === b.toString()]; | ||
const matcher = matcherFactory(util, customEqualityTesters); | ||
|
||
const result = matcher.compare(wrapper, 'foo', 'false'); | ||
expect(result.pass).toEqual(true); | ||
}); | ||
|
||
it('works with Jasmine >= 3.6 without triggering deprecation warnings', () => { | ||
const matcherFactory = createMatcherFactory(); | ||
const Fixture = require('./fixtures/toHaveState.fixture'); | ||
const wrapper = shallow(React.createElement(Fixture)); | ||
const customEqualityTesters = [(a, b) => a.toString() === b.toString()]; | ||
customEqualityTesters.deprecated = true; | ||
const util = jasmine.createSpyObj('matchersUtil', ['equals']); | ||
util.equals.and.callFake((a, b) => customEqualityTesters[0](a, b)); | ||
const matcher = matcherFactory(util, customEqualityTesters); | ||
|
||
const result = matcher.compare(wrapper, 'foo', 'false'); | ||
expect(result.pass).toEqual(true); | ||
expect(util.equals).toHaveBeenCalled(); | ||
|
||
// Make sure we don't trigger any deprecation warnings | ||
expect(matcherFactory.length).toBeLessThan(2); | ||
expect(util.equals).not.toHaveBeenCalledWith( | ||
jasmine.anything(), | ||
jasmine.anything(), | ||
customEqualityTesters | ||
); | ||
}); | ||
|
||
it('works if Jasmine does not pass customEqualityTesters', () => { | ||
const matcherFactory = createMatcherFactory(); | ||
const Fixture = require('./fixtures/toHaveState.fixture'); | ||
const wrapper = shallow(React.createElement(Fixture)); | ||
const util = { | ||
equals: () => true, | ||
}; | ||
const matcher = matcherFactory(util); | ||
|
||
const result = matcher.compare(wrapper, 'foo', 'false'); | ||
expect(result.pass).toEqual(true); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed if compatibility with jasmine 3.5 and earlier is not wanted.