Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused config #488

Merged
merged 1 commit into from
Feb 13, 2024
Merged

remove unused config #488

merged 1 commit into from
Feb 13, 2024

Conversation

IlyaLisov
Copy link
Contributor

@IlyaLisov IlyaLisov commented Feb 12, 2024

As I examined, there are no usages of sensetive property of Rultor in this project. Also there are no mentions of such property in Rultor doc.

it closes #486


PR-Codex overview

This PR focuses on updating the Maven version based on the provided tag.

Detailed summary

  • Removed settings.xml from the list of sensitive files in .rultor.yml.
  • Added a script to check if the provided tag matches the pattern ^[0-9]+\.[0-9]+\.[0-9]+$.
  • If the tag matches the pattern, the Maven version is updated using mvn versions:set with the new version set to the tag value.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented Feb 12, 2024

@IlyaLisov thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@IlyaLisov
Copy link
Contributor Author

@h1alexbel I'll be glad to see review from you

@zoeself
Copy link
Collaborator

zoeself commented Feb 12, 2024

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-02-15T15:19:13.817827.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 12, 2024

@rultor merge

@IlyaLisov @h1alexbel Can't merge this pull requests, because the file .rultor.yml was modified. This is a security threat. Make a separate pull request with the modification of this particular file and ask project architect to merge it manually.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed8f014) 99.00% compared to head (6dd6dd4) 99.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #488   +/-   ##
=========================================
  Coverage     99.00%   99.00%           
  Complexity      173      173           
=========================================
  Files            82       82           
  Lines           504      504           
  Branches          1        1           
=========================================
  Hits            499      499           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel h1alexbel merged commit 29fcdb9 into eo-cqrs:master Feb 13, 2024
8 checks passed
@h1alexbel
Copy link
Member

@IlyaLisov thanks so much!

@IlyaLisov IlyaLisov deleted the #486 branch February 13, 2024 07:55
@zoeself
Copy link
Collaborator

zoeself commented Feb 13, 2024

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in sensetive configuration in .rultor.yml
5 participants