-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused config #488
remove unused config #488
Conversation
@IlyaLisov thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
@h1alexbel I'll be glad to see review from you |
@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
@rultor merge |
@IlyaLisov @h1alexbel Can't merge this pull requests, because the file |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
=========================================
Coverage 99.00% 99.00%
Complexity 173 173
=========================================
Files 82 82
Lines 504 504
Branches 1 1
=========================================
Hits 499 499
Misses 5 5 ☔ View full report in Codecov by Sentry. |
@IlyaLisov thanks so much! |
@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
As I examined, there are no usages of
sensetive
property of Rultor in this project. Also there are no mentions of such property in Rultor doc.it closes #486
PR-Codex overview
This PR focuses on updating the Maven version based on the provided tag.
Detailed summary
settings.xml
from the list of sensitive files in.rultor.yml
.^[0-9]+\.[0-9]+\.[0-9]+$
.mvn versions:set
with the new version set to the tag value.