Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#507): reports-check #508

Merged
merged 1 commit into from
May 27, 2024
Merged

feat(#507): reports-check #508

merged 1 commit into from
May 27, 2024

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented May 27, 2024

ref #507

@zoeself
Copy link
Collaborator

zoeself commented May 27, 2024

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@zoeself
Copy link
Collaborator

zoeself commented May 27, 2024

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2024-05-30T10:29:16.706230.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (654e4ae) to head (c55af9d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #508   +/-   ##
=========================================
  Coverage     99.00%   99.00%           
  Complexity      173      173           
=========================================
  Files            82       82           
  Lines           504      504           
  Branches          1        1           
=========================================
  Hits            499      499           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel
Copy link
Member Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 27, 2024

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8aa9403 into master May 27, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented May 27, 2024

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 3min)

@h1alexbel h1alexbel deleted the reports branch May 27, 2024 11:48
@zoeself
Copy link
Collaborator

zoeself commented May 27, 2024

@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants